Skip to content

Mqe 1361: Unable to use empty string literal as argument to selector in tests #281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Dec 4, 2018
Merged

Mqe 1361: Unable to use empty string literal as argument to selector in tests #281

merged 4 commits into from
Dec 4, 2018

Conversation

jilu1
Copy link
Contributor

@jilu1 jilu1 commented Nov 28, 2018

Description

Fixed Issues (if relevant)

  1. magento/magento2-functional-testing-framework#<issue_number>: Issue title
  2. ...

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/verification tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
  • Changes to Framework doesn't have backward incompatible changes for tests or have related Pull Request with fixes to tests

@jilu1 jilu1 changed the title Mqe 1361 Mqe 1361: Unable to use empty string literal as argument to selector in tests Nov 28, 2018
KevinBKozan
KevinBKozan approved these changes Nov 29, 2018
View reviewed changes
Copy link
Contributor

@KevinBKozan KevinBKozan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, verification test covers usecase well.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 57.054% when pulling f75f380 on MQE-1361 into a245731 on develop.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 57.054% when pulling f75f380 on MQE-1361 into a245731 on develop.

@jilu1 jilu1 merged commit d5265e9 into develop Dec 4, 2018
@jilu1 jilu1 deleted the MQE-1361 branch December 4, 2018 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KevinBKozan KevinBKozan KevinBKozan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jilu1 @coveralls @KevinBKozan